Re: [PATCH v6 22/25] target/riscv: Don't modify SUM with is_debug

[Alistair Francis]

On Sat, Mar 25, 2023 at 9:55 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> If we want to give the debugger a greater view of memory than
> the cpu, we should simply disable the access check entirely,
> not simply for this one corner case.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/cpu_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
> index b26840e46c..850817edfd 100644
> --- a/target/riscv/cpu_helper.c
> +++ b/target/riscv/cpu_helper.c
> @@ -837,7 +837,7 @@ static int get_physical_address(CPURISCVState *env, 
> hwaddr *physical,
>          }
>          widened = 2;
>      }
> -    sum = mmuidx_sum(mmu_idx) || is_debug;
> +    sum = mmuidx_sum(mmu_idx);
>      switch (vm) {
>      case VM_1_10_SV32:
>        levels = 2; ptidxbits = 10; ptesize = 4; break;
> --
> 2.34.1
>
>