[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 21/25] target/riscv: Suppress pte update with is_debug
From: |
Alistair Francis |
Subject: |
Re: [PATCH v6 21/25] target/riscv: Suppress pte update with is_debug |
Date: |
Tue, 11 Apr 2023 14:30:33 +1000 |
On Sat, Mar 25, 2023 at 10:56 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The debugger should not modify PTE_A or PTE_D.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
> index ce12dcec1d..b26840e46c 100644
> --- a/target/riscv/cpu_helper.c
> +++ b/target/riscv/cpu_helper.c
> @@ -1015,7 +1015,7 @@ restart:
> (access_type == MMU_DATA_STORE ? PTE_D : 0);
>
> /* Page table updates need to be atomic with MTTCG enabled */
> - if (updated_pte != pte) {
> + if (updated_pte != pte && !is_debug) {
> if (!hade) {
> return TRANSLATE_FAIL;
> }
> --
> 2.34.1
>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v6 21/25] target/riscv: Suppress pte update with is_debug,
Alistair Francis <=