Re: [PATCH v4 4/7] dump: Introduce win_dump_available()

[Thomas Huth]

On 24/02/2023 00.17, Philippe Mathieu-Daudé wrote:
> Remove a pair of TARGET_X86_64 #ifdef'ry by introducing
> the win_dump_available() method. We'll soon extract it
> to a stub file for non-x86 targets.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   dump/dump.c     | 23 +++++++++++++----------
>   dump/win_dump.c |  5 +++++
>   dump/win_dump.h |  3 +++
>   3 files changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/dump/dump.c b/dump/dump.c
> index 3784a9054d..c356a88be1 100644
> --- a/dump/dump.c
> +++ b/dump/dump.c
> @@ -30,9 +30,15 @@
>   #include "qemu/main-loop.h"
>   #include "hw/misc/vmcoreinfo.h"
>   #include "migration/blocker.h"
> -
> -#ifdef TARGET_X86_64
>   #include "win_dump.h"
> +
> +#ifndef TARGET_X86_64
> +bool win_dump_available(Error **errp)
> +{
> +    error_setg(errp, "Windows dump is only available for x86-64");
> +
> +    return false;
> +}
>   #endif

I think I'd prefer to introduce the stub file immediately here already, but 
it's just a matter of taste.

So with the indentation fixed (that Richard mentioned):

Reviewed-by: Thomas Huth <thuth@redhat.com>