Re: [PATCH v4 4/7] dump: Introduce win_dump_available()

[Richard Henderson]

On 2/23/23 13:17, Philippe Mathieu-Daudé wrote:
> @@ -2130,12 +2136,10 @@ void qmp_dump_guest_memory(bool paging, const char 
> *file,
>       }
>   #endif
>   
> -#ifndef TARGET_X86_64
> -    if (has_format && format == DUMP_GUEST_MEMORY_FORMAT_WIN_DMP) {
> -        error_setg(errp, "Windows dump is only available for x86-64");
> +    if (has_format && format == DUMP_GUEST_MEMORY_FORMAT_WIN_DMP
> +            && !win_dump_available(errp)) {

Indentation is off.

Otherwise looks plausible as an intermediate step before more targets.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~