Re: [PATCH v4 2/7] dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size()

[Thomas Huth]

On 24/02/2023 00.17, Philippe Mathieu-Daudé wrote:
> TARGET_PAGE_SIZE is target specific. In preparation of
> making dump.c target-agnostic, replace the compile-time
> TARGET_PAGE_SIZE definition by runtime qemu_target_page_size().
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   dump/dump.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/dump/dump.c b/dump/dump.c
> index 7101169ecb..3784a9054d 100644
> --- a/dump/dump.c
> +++ b/dump/dump.c
> @@ -15,6 +15,7 @@
>   #include "qemu/cutils.h"
>   #include "elf.h"
>   #include "exec/hwaddr.h"
> +#include "exec/target_page.h"
>   #include "monitor/monitor.h"
>   #include "sysemu/kvm.h"
>   #include "sysemu/dump.h"
> @@ -1859,7 +1860,7 @@ static void dump_init(DumpState *s, int fd, bool 
> has_format,
>       }
>   
>       if (!s->dump_info.page_size) {
> -        s->dump_info.page_size = TARGET_PAGE_SIZE;
> +        s->dump_info.page_size = qemu_target_page_size();
>       }
>   
>       s->note_size = cpu_get_note_size(s->dump_info.d_class,

Reviewed-by: Thomas Huth <thuth@redhat.com>