[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/12] hw/acpi: Dumb down acpi_table_add() stub
From: |
Markus Armbruster |
Subject: |
[PULL 06/12] hw/acpi: Dumb down acpi_table_add() stub |
Date: |
Thu, 23 Feb 2023 14:46:20 +0100 |
The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.
acpi_table_add() is only ever called on behalf of CLI option
-acpitable. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386,
it is reachable only for these targets. Since they provide a real
acpi_table_add(), the stub is unreachable.
There's no point in unreachable code keeping QERR_UNSUPPORTED alive.
Dumb it down to g_assert_not_reached().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230207075115.1525-7-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
---
hw/acpi/acpi-stub.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/acpi/acpi-stub.c b/hw/acpi/acpi-stub.c
index 4c9d081ed4..e268ce9b1a 100644
--- a/hw/acpi/acpi-stub.c
+++ b/hw/acpi/acpi-stub.c
@@ -19,11 +19,9 @@
*/
#include "qemu/osdep.h"
-#include "qapi/error.h"
-#include "qapi/qmp/qerror.h"
#include "hw/acpi/acpi.h"
void acpi_table_add(const QemuOpts *opts, Error **errp)
{
- error_setg(errp, QERR_UNSUPPORTED);
+ g_assert_not_reached();
}
--
2.39.0
- [PULL 03/12] dump: Assert cpu_get_note_size() can't fail, (continued)
- [PULL 03/12] dump: Assert cpu_get_note_size() can't fail, Markus Armbruster, 2023/02/23
- [PULL 09/12] replay: Simplify setting replay blockers, Markus Armbruster, 2023/02/23
- [PULL 10/12] hw/core: Improve the query-hotpluggable-cpus error message, Markus Armbruster, 2023/02/23
- [PULL 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h", Markus Armbruster, 2023/02/23
- [PULL 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message, Markus Armbruster, 2023/02/23
- [PULL 05/12] hw/smbios: Dumb down smbios_entry_add() stub, Markus Armbruster, 2023/02/23
- [PULL 12/12] rocker: Tweak stubbed out monitor commands' error messages, Markus Armbruster, 2023/02/23
- [PULL 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED, Markus Armbruster, 2023/02/23
- [PULL 04/12] hw/core: Improve error message when machine doesn't provide NMIs, Markus Armbruster, 2023/02/23
- [PULL 07/12] hw/acpi: Move QMP command to hw/core/, Markus Armbruster, 2023/02/23
- [PULL 06/12] hw/acpi: Dumb down acpi_table_add() stub,
Markus Armbruster <=
- Re: [PULL 00/12] Error reporting patches patches for 2023-02-23, Peter Maydell, 2023/02/24