[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED
From: |
Markus Armbruster |
Subject: |
[PULL 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED |
Date: |
Thu, 23 Feb 2023 14:46:22 +0100 |
slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED.
This macro never existed. The reference got added in commit
e3d4d25206a "guest agent: add guest agent RPCs/commands" along with
QERR_QGA_LOGGING_FAILED, so maybe that one was meant. However,
QERR_QGA_LOGGING_FAILED was never actually used, and was removed in
commit d73f0beadb5 "qerror.h: Remove unused error classes".
Drop the dangling reference.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230207075115.1525-9-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---
qga/commands.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/qga/commands.c b/qga/commands.c
index 360077364e..172826f8f8 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -32,9 +32,8 @@
#define GUEST_FILE_READ_COUNT_MAX (48 * MiB)
/* Note: in some situations, like with the fsfreeze, logging may be
- * temporarilly disabled. if it is necessary that a command be able
- * to log for accounting purposes, check ga_logging_enabled() beforehand,
- * and use the QERR_QGA_LOGGING_DISABLED to generate an error
+ * temporarily disabled. if it is necessary that a command be able
+ * to log for accounting purposes, check ga_logging_enabled() beforehand.
*/
void slog(const gchar *fmt, ...)
{
--
2.39.0
- [PULL 00/12] Error reporting patches patches for 2023-02-23, Markus Armbruster, 2023/02/23
- [PULL 02/12] dump: Improve error message when target doesn't support memory dump, Markus Armbruster, 2023/02/23
- [PULL 03/12] dump: Assert cpu_get_note_size() can't fail, Markus Armbruster, 2023/02/23
- [PULL 09/12] replay: Simplify setting replay blockers, Markus Armbruster, 2023/02/23
- [PULL 10/12] hw/core: Improve the query-hotpluggable-cpus error message, Markus Armbruster, 2023/02/23
- [PULL 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h", Markus Armbruster, 2023/02/23
- [PULL 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message, Markus Armbruster, 2023/02/23
- [PULL 05/12] hw/smbios: Dumb down smbios_entry_add() stub, Markus Armbruster, 2023/02/23
- [PULL 12/12] rocker: Tweak stubbed out monitor commands' error messages, Markus Armbruster, 2023/02/23
- [PULL 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED,
Markus Armbruster <=
- [PULL 04/12] hw/core: Improve error message when machine doesn't provide NMIs, Markus Armbruster, 2023/02/23
- [PULL 07/12] hw/acpi: Move QMP command to hw/core/, Markus Armbruster, 2023/02/23
- [PULL 06/12] hw/acpi: Dumb down acpi_table_add() stub, Markus Armbruster, 2023/02/23
- Re: [PULL 00/12] Error reporting patches patches for 2023-02-23, Peter Maydell, 2023/02/24