[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/12] hw/core: Improve error message when machine doesn't provide
From: |
Markus Armbruster |
Subject: |
[PULL 04/12] hw/core: Improve error message when machine doesn't provide NMIs |
Date: |
Thu, 23 Feb 2023 14:46:18 +0100 |
The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.
Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague
error message
(qemu) nmi
Error: this feature or command is not currently supported
to
Error: machine does not provide NMIs
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230207075115.1525-5-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
---
hw/core/nmi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/core/nmi.c b/hw/core/nmi.c
index 481c4b3c7e..a7bce8a04a 100644
--- a/hw/core/nmi.c
+++ b/hw/core/nmi.c
@@ -22,7 +22,6 @@
#include "qemu/osdep.h"
#include "hw/nmi.h"
#include "qapi/error.h"
-#include "qapi/qmp/qerror.h"
#include "qemu/module.h"
#include "monitor/monitor.h"
@@ -70,7 +69,7 @@ void nmi_monitor_handle(int cpu_index, Error **errp)
if (ns.handled) {
error_propagate(errp, ns.err);
} else {
- error_setg(errp, QERR_UNSUPPORTED);
+ error_setg(errp, "machine does not provide NMIs");
}
}
--
2.39.0
- [PULL 00/12] Error reporting patches patches for 2023-02-23, Markus Armbruster, 2023/02/23
- [PULL 02/12] dump: Improve error message when target doesn't support memory dump, Markus Armbruster, 2023/02/23
- [PULL 03/12] dump: Assert cpu_get_note_size() can't fail, Markus Armbruster, 2023/02/23
- [PULL 09/12] replay: Simplify setting replay blockers, Markus Armbruster, 2023/02/23
- [PULL 10/12] hw/core: Improve the query-hotpluggable-cpus error message, Markus Armbruster, 2023/02/23
- [PULL 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h", Markus Armbruster, 2023/02/23
- [PULL 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message, Markus Armbruster, 2023/02/23
- [PULL 05/12] hw/smbios: Dumb down smbios_entry_add() stub, Markus Armbruster, 2023/02/23
- [PULL 12/12] rocker: Tweak stubbed out monitor commands' error messages, Markus Armbruster, 2023/02/23
- [PULL 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED, Markus Armbruster, 2023/02/23
- [PULL 04/12] hw/core: Improve error message when machine doesn't provide NMIs,
Markus Armbruster <=
- [PULL 07/12] hw/acpi: Move QMP command to hw/core/, Markus Armbruster, 2023/02/23
- [PULL 06/12] hw/acpi: Dumb down acpi_table_add() stub, Markus Armbruster, 2023/02/23
- Re: [PULL 00/12] Error reporting patches patches for 2023-02-23, Peter Maydell, 2023/02/24