Re: [PATCH] hw/ide/ahci: trace ncq write command as write instead of read

[John Snow]

On Mon, Feb 20, 2023 at 3:12 AM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> On 17/2/23 11:31, Fiona Ebner wrote:
> > Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events")
> > Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> > ---
> >
> > Or should it be sorted alphabetically below execute_ncq_command_unsup?
> > I felt read and write belong close together and this reflects the
> > positions in the code.
> >
> >   hw/ide/ahci.c       | 4 ++--
> >   hw/ide/trace-events | 1 +
> >   2 files changed, 3 insertions(+), 2 deletions(-)
>
> > diff --git a/hw/ide/trace-events b/hw/ide/trace-events
> > index 15d7921f15..5ef344ae73 100644
> > --- a/hw/ide/trace-events
> > +++ b/hw/ide/trace-events
> > @@ -91,6 +91,7 @@ ahci_populate_sglist_short_map(void *s, int port) 
> > "ahci(%p)[%d]: mapped less tha
> >   ahci_populate_sglist_bad_offset(void *s, int port, int off_idx, int64_t 
> > off_pos) "ahci(%p)[%d]: Incorrect offset! off_idx: %d, off_pos: %"PRId64
> >   ncq_finish(void *s, int port, uint8_t tag) "ahci(%p)[%d][tag:%d]: NCQ 
> > transfer finished"
> >   execute_ncq_command_read(void *s, int port, uint8_t tag, int count, 
> > int64_t lba) "ahci(%p)[%d][tag:%d]: NCQ reading %d sectors from LBA %"PRId64
> > +execute_ncq_command_write(void *s, int port, uint8_t tag, int count, 
> > int64_t lba) "ahci(%p)[%d][tag:%d]: NCQ writing %d sectors to LBA %"PRId64
>
> Note that ideally the tag format should be '%u' (pre-existing).
>
> I'll carry this patch along with other QDev IDE patches I plan to merge
> (with John's blessing).

Sounds good to me, thank you Phil.

--js