qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/ide/ahci: trace ncq write command as write instead of rea


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] hw/ide/ahci: trace ncq write command as write instead of read
Date: Fri, 17 Feb 2023 13:26:59 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 17/2/23 11:31, Fiona Ebner wrote:
Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events")

Oops

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Or should it be sorted alphabetically below execute_ncq_command_unsup?

No, there is no convention...

I felt read and write belong close together and this reflects the
positions in the code.

probably for this reason.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]