[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/ide/ahci: trace ncq write command as write instead of rea
|
From: |
John Snow |
|
Subject: |
Re: [PATCH] hw/ide/ahci: trace ncq write command as write instead of read |
|
Date: |
Fri, 17 Feb 2023 15:12:11 -0500 |
On Fri, Feb 17, 2023 at 7:27 AM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> On 17/2/23 11:31, Fiona Ebner wrote:
> > Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events")
>
> Oops
Seconding the whoops.
>
> > Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> > ---
> >
> > Or should it be sorted alphabetically below execute_ncq_command_unsup?
>
> No, there is no convention...
>
> > I felt read and write belong close together and this reflects the
> > positions in the code.
>
> probably for this reason.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Thanks!
>
Reviewed-by: John Snow <jsnow@redhat.com>