Re: [PATCH v3 0/4] Adds support for running QEMU natively on windows-arm64

[Philippe Mathieu-Daudé]

Hi Pierrick,

On 20/2/23 12:12, Pierrick Bouvier wrote:
> Since v2:
>
> - Delete superfluous comment on unreachable code
> - Fix style for multiline comments
>
> Since v1:
>
> - Comment why we use generic version of flush_idcache_range
> - Ensure __mingw_setjmp/longjmp are available using meson
> - Fix a warning by calling g_assert_not_reached() instead of initializing a
>    variable
>
> As before this was tested with:
> - make check
> - boot an x64 debian bullseye vm
> - boot an arm64 ubuntu 22.10 vm
>
> Thanks
>
> Pierrick Bouvier (4):
>    util/cacheflush: fix cache on windows-arm64
>    sysemu/os-win32: fix setjmp/longjmp on windows-arm64
>    qga/vss-win32: fix warning for clang++-15
>    target/ppc: fix warning with clang-15

You forgot to include the 'Reviewed-by/Acked-by' tags from your previous
versions. See from these guidelines:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review

  When reviewing a large series, a reviewer can reply to some of the
  patches with a Reviewed-by tag, stating that they are happy with
  that patch in isolation [...]. You should then update those commit
  messages by hand to include the Reviewed-by tag, so that in the next
  revision, reviewers can spot which patches were already clean from
  the previous round.

No need for a v4, you can reply to each patch with the missed tags.