Re: [PATCH v3 4/4] target/ppc: fix warning with clang-15

[Pierrick Bouvier]

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

On 2/20/23 12:12, Pierrick Bouvier wrote:
> When compiling for windows-arm64 using clang-15, it reports a sometimes
> uninitialized variable. This seems to be a false positive, as a default
> case guards switch expressions, preventing to return an uninitialized
> value, but clang seems unhappy with assert(0) definition.
>
> Change code to g_assert_not_reached() fix the warning.
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   target/ppc/dfp_helper.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c
> index cc024316d5..5967ea07a9 100644
> --- a/target/ppc/dfp_helper.c
> +++ b/target/ppc/dfp_helper.c
> @@ -121,7 +121,7 @@ static void dfp_set_round_mode_from_immediate(uint8_t r, 
> uint8_t rmc,
>           case 3: /* use FPSCR rounding mode */
>               return;
>           default:
> -            assert(0); /* cannot get here */
> +            g_assert_not_reached();
>           }
>       } else { /* r == 1 */
>           switch (rmc & 3) {
> @@ -138,7 +138,7 @@ static void dfp_set_round_mode_from_immediate(uint8_t r, 
> uint8_t rmc,
>               rnd = DEC_ROUND_HALF_DOWN;
>               break;
>           default:
> -            assert(0); /* cannot get here */
> +            g_assert_not_reached();
>           }
>       }
>       decContextSetRounding(&dfp->context, rnd);