[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND v5 25/28] target/avocado: Pass parameters to migration
From: |
Peter Maydell |
Subject: |
Re: [PATCH RESEND v5 25/28] target/avocado: Pass parameters to migration test on aarch64 |
Date: |
Thu, 16 Feb 2023 16:32:39 +0000 |
On Mon, 13 Feb 2023 at 20:33, Fabiano Rosas <farosas@suse.de> wrote:
>
> The migration tests are currently broken for an aarch64 host because
> the tests pass no 'machine' and 'cpu' options on the QEMU command
> line. Most other architectures define a default value in QEMU for
> these options, but arm does not.
>
> Add these options to the test class in case the test is being executed
> in an aarch64 host.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Acked-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> tests/avocado/migration.py | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/tests/avocado/migration.py b/tests/avocado/migration.py
> index 4b25680c50..ffd3db0f35 100644
> --- a/tests/avocado/migration.py
> +++ b/tests/avocado/migration.py
> @@ -11,6 +11,8 @@
>
>
> import tempfile
> +import os
> +
> from avocado_qemu import QemuSystemTest
> from avocado import skipUnless
>
> @@ -26,6 +28,14 @@ class Migration(QemuSystemTest):
>
> timeout = 10
>
> + def setUp(self):
> + super().setUp()
> +
> + arch = os.uname()[4]
> + if arch == 'aarch64':
> + self.machine = 'virt'
> + self.cpu = 'max'
> +
> @staticmethod
> def migration_finished(vm):
> return vm.command('query-migrate')['status'] in ('completed',
> 'failed')
> --
This looks odd. Don't we run this test in our CI currently?
I'm not sure that specialcasing aarch64 here is the right
approach -- David, any opinions?
thanks
-- PMM
- [PATCH RESEND v5 17/28] target/arm: Move cortex sysregs into cpregs.c, (continued)
- [PATCH RESEND v5 17/28] target/arm: Move cortex sysregs into cpregs.c, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 18/28] tests/avocado: Skip tests that require a missing accelerator, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 19/28] tests/avocado: Tag TCG tests with accel:tcg, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 20/28] target/arm: Move 64-bit TCG CPUs into tcg/, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 21/28] target/arm: move cpu_tcg to tcg/cpu32.c, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 22/28] target/arm: Use "max" as default cpu for the virt machine with KVM, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 23/28] tests/qtest: arm-cpu-features: Match tests to required accelerators, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 24/28] tests/qtest: Restrict tpm-tis-devices-{swtpm}-test to CONFIG_TCG, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 25/28] target/avocado: Pass parameters to migration test on aarch64, Fabiano Rosas, 2023/02/13
- Re: [PATCH RESEND v5 25/28] target/avocado: Pass parameters to migration test on aarch64,
Peter Maydell <=
- [PATCH RESEND v5 26/28] arm/Kconfig: Always select SEMIHOSTING when TCG is present, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 27/28] arm/Kconfig: Do not build TCG-only boards on a KVM-only build, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 28/28] gitlab-ci: Check building KVM-only aarch64 target, Fabiano Rosas, 2023/02/13
- Re: [PATCH RESEND v5 00/28] target/arm: Allow CONFIG_TCG=n builds, Peter Maydell, 2023/02/16