Re: [PATCH RESEND v5 17/28] target/arm: Move cortex sysregs into cpregs.c

[Peter Maydell]

On Mon, 13 Feb 2023 at 20:32, Fabiano Rosas <farosas@suse.de> wrote:
>
> The file cpu_tcg.c is about to be moved into the tcg/ directory, so
> move the register definitions into cpregs.c along with all the others.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/arm/cpregs.c    | 59 ++++++++++++++++++++++++++++++++++++++++++
>  target/arm/cpregs.h    |  6 +++++
>  target/arm/cpu64.c     |  1 +
>  target/arm/cpu_tcg.c   | 59 ------------------------------------------
>  target/arm/internals.h |  6 -----
>  5 files changed, 66 insertions(+), 65 deletions(-)

This patch too is throwing more code into cpregs.c. These
are nicely separated out because they are the impdef
registers for the CPU models being defined here. This
is a much better place for them to live, since again
cpu_tcg.c is a smaller source file with a more well-defined
purpose.

thanks
-- PMM