[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging
From: |
Mostafa Saleh |
Subject: |
Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging |
Date: |
Thu, 16 Feb 2023 13:53:55 +0000 |
Hi Eric,
On Thu, Feb 16, 2023 at 11:17:34AM +0100, Eric Auger wrote:
> > }
> >
> > - *key = smmu_get_iotlb_key(cfg->asid, new->entry.iova, tg, new->level);
> > + *key = smmu_get_iotlb_key(cfg->asid, cfg->s2cfg.vmid, new->entry.iova,
> > + tg, new->level);
> > trace_smmu_iotlb_insert(cfg->asid, new->entry.iova, tg, new->level);
> you may update the trace point as well
I can add a stage argument here, however I don’t think it is necessary
now as TLBs are either used for stage-1 or stage-2, not both.
Thanks,
Mostafa
[RFC PATCH 15/16] hw/arm/smmuv3: Add fault configuration for stage-2, Mostafa Saleh, 2023/02/05
[RFC PATCH 16/16] hw/arm/smmuv3: Enable stage-2 support, Mostafa Saleh, 2023/02/05