Re: [PATCH v4] hw/arm/smmuv3: Add GBPA register

[Richard Henderson]

On 2/13/23 00:57, Peter Maydell wrote:
> On Sat, 11 Feb 2023 at 23:49, Richard Henderson
> <richard.henderson@linaro.org> wrote:
> > On 2/10/23 12:19, Mostafa Saleh wrote:
> > > @@ -1512,6 +1553,10 @@ static const VMStateDescription vmstate_smmuv3 = {
> > >
> > >            VMSTATE_END_OF_LIST(),
> > >        },
> > > +    .subsections = (const VMStateDescription * []) {
> > > +        &vmstate_gbpa,
> > > +        NULL
> > > +    }
> >
> > Actually, I suspect that you need a pre_load hook that resets gbpa, which will 
> > then be
> > overwritten if and only if the saved value != reset value.
>
> VM loads are guaranteed to start from a VM state which is freshly
> reset, so the device's reset method is sufficient for this.

Thanks for the confirmation.

r~