Re: [PATCH v4] hw/arm/smmuv3: Add GBPA register

[Eric Auger]

Hi Mostafa,

On 2/12/23 00:34, Richard Henderson wrote:
> On 2/10/23 12:19, Mostafa Saleh wrote:
>> +static bool smmuv3_gbpa_needed(void *opaque)
>> +{
>> +    SMMUv3State *s = opaque;
>> +
>> +    /* Only migrate GBPA if it has different reset value. */
>> +    if (s->gbpa != SMMU_GBPA_RESET_VAL) {
>> +        return true;
>> +    }
>> +
>> +    return false;
>
> Just "return s->gbpa != SMMU_GBPA_RESET_VAL;".
>
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

With this suggestion, it looks good to me.

Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric


>
>
> r~
>