[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 15/15] qapi: introduce query-hotplug command
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v3 15/15] qapi: introduce query-hotplug command |
|
Date: |
Fri, 10 Feb 2023 11:09:49 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> Add a command that returns same information like HOTPLUG_STATE event.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Events and queries commonly come paired: management applications want
the event so they don't have to poll, and they want the query so they
can resynchronize after a disconnect. Adding an event without a query
should make reviewers ask why no query.
You add the event in PATCH 13, and the query now. I'd add them both in
a single patch. Matter of taste. If you keep them separate, please
have the first patch mention the second will follow shortly, to help
reviewers.
- [PATCH v3 06/15] pcie: pcie_cap_slot_write_config(): use correct macro, (continued)
- [PATCH v3 06/15] pcie: pcie_cap_slot_write_config(): use correct macro, Vladimir Sementsov-Ogievskiy, 2023/02/09
- [PATCH v3 08/15] pcie: drop unused PCIExpressIndicator, Vladimir Sementsov-Ogievskiy, 2023/02/09
- [PATCH v3 10/15] pcie: introduce pcie_sltctl_powered_off() helper, Vladimir Sementsov-Ogievskiy, 2023/02/09
- [PATCH v3 03/15] pci/shpc: shpc_slot_command(): handle PWRONLY -> ENABLED transition, Vladimir Sementsov-Ogievskiy, 2023/02/09
- [PATCH v3 07/15] pcie_regs: drop duplicated indicator value macros, Vladimir Sementsov-Ogievskiy, 2023/02/09
- [PATCH v3 01/15] pci/shpc: set attention led to OFF on reset, Vladimir Sementsov-Ogievskiy, 2023/02/09
- [PATCH v3 09/15] pcie: pcie_cap_slot_enable_power() use correct helper, Vladimir Sementsov-Ogievskiy, 2023/02/09
- [PATCH v3 11/15] pcie: set power indicator to off on reset by default, Vladimir Sementsov-Ogievskiy, 2023/02/09
- [PATCH v3 15/15] qapi: introduce query-hotplug command, Vladimir Sementsov-Ogievskiy, 2023/02/09
- Re: [PATCH v3 15/15] qapi: introduce query-hotplug command,
Markus Armbruster <=
- [PATCH v3 13/15] qapi: add HOTPLUG_STATE event, Vladimir Sementsov-Ogievskiy, 2023/02/09
- Re: [PATCH v3 13/15] qapi: add HOTPLUG_STATE event, Markus Armbruster, 2023/02/10
[PATCH v3 12/15] pci: introduce pci_find_the_only_child(), Vladimir Sementsov-Ogievskiy, 2023/02/09