Re: [PATCH v3 13/15] qapi: add HOTPLUG_STATE event

[Vladimir Sementsov-Ogievskiy]

On 10.02.23 15:01, Markus Armbruster wrote:
> > > What do @hotplug-device and @device name?  Are these qdev-id?
> > >
> > > What kind of paths are @hotplug-path and @path?  Are these paths to an
> > > object device in the QOM tree?  Which object?
> > device / path is same name and path as for DEVICE_DELETED
> Got it.  But there we have just one device, and here we have two.  Which
> two?

One is "bus" in which we insert the device. I'm not sure that's it correct to call pcie-root-port a 
"bus", but on the other hand in device_add command it's a "bus" argument. In some arguments in code 
it's called hotplug_dev or something like that. Probably "bus" is better.

> Also, DEVICE_DELETED's doc comment is better:
>
>      # @device: the device's ID if it has one
>      #
>      # @path: the device's QOM path
>
> Suggest to steal from there.

OK, agree.

--
Best regards,
Vladimir