[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 31/32] target/riscv: fix SBI getchar handler for KVM
From: |
Alistair Francis |
Subject: |
[PULL 31/32] target/riscv: fix SBI getchar handler for KVM |
Date: |
Tue, 7 Feb 2023 17:09:42 +1000 |
From: Vladimir Isaev <vladimir.isaev@syntacore.com>
Character must be returned via ret[0] field (copied to a0 by KVM).
Return value should be set to 0 to indicate successful processing.
Signed-off-by: Vladimir Isaev <vladimir.isaev@syntacore.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20230203135155.12449-1-vladimir.isaev@syntacore.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
target/riscv/kvm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c
index 30f21453d6..0f932a5b96 100644
--- a/target/riscv/kvm.c
+++ b/target/riscv/kvm.c
@@ -467,10 +467,11 @@ static int kvm_riscv_handle_sbi(CPUState *cs, struct
kvm_run *run)
case SBI_EXT_0_1_CONSOLE_GETCHAR:
ret = qemu_chr_fe_read_all(serial_hd(0)->be, &ch, sizeof(ch));
if (ret == sizeof(ch)) {
- run->riscv_sbi.args[0] = ch;
+ run->riscv_sbi.ret[0] = ch;
} else {
- run->riscv_sbi.args[0] = -1;
+ run->riscv_sbi.ret[0] = -1;
}
+ ret = 0;
break;
default:
qemu_log_mask(LOG_UNIMP,
--
2.39.1
- [PULL 19/32] RISC-V: Adding XTheadBs ISA extension, (continued)
- [PULL 19/32] RISC-V: Adding XTheadBs ISA extension, Alistair Francis, 2023/02/07
- [PULL 20/32] RISC-V: Adding XTheadCondMov ISA extension, Alistair Francis, 2023/02/07
- [PULL 21/32] RISC-V: Adding T-Head multiply-accumulate instructions, Alistair Francis, 2023/02/07
- [PULL 22/32] RISC-V: Adding T-Head MemPair extension, Alistair Francis, 2023/02/07
- [PULL 23/32] RISC-V: Adding T-Head MemIdx extension, Alistair Francis, 2023/02/07
- [PULL 24/32] RISC-V: Adding T-Head FMemIdx extension, Alistair Francis, 2023/02/07
- [PULL 25/32] RISC-V: Set minimum priv version for Zfh to 1.11, Alistair Francis, 2023/02/07
- [PULL 26/32] RISC-V: Add initial support for T-Head C906, Alistair Francis, 2023/02/07
- [PULL 27/32] RISC-V: Adding XTheadFmv ISA extension, Alistair Francis, 2023/02/07
- [PULL 28/32] target/riscv: add a MAINTAINERS entry for XThead* extension support, Alistair Francis, 2023/02/07
- [PULL 31/32] target/riscv: fix SBI getchar handler for KVM,
Alistair Francis <=
- [PULL 29/32] target/riscv: fix for virtual instr exception, Alistair Francis, 2023/02/07
- [PULL 32/32] hw/riscv: virt: Simplify virt_{get,set}_aclint(), Alistair Francis, 2023/02/07
- [PULL 30/32] target/riscv: fix ctzw behavior, Alistair Francis, 2023/02/07
- Re: [PULL 00/32] riscv-to-apply queue, Peter Maydell, 2023/02/07