Re: [PULL 00/35] Monitor patches for 2023-02-03

[Peter Maydell]

On Fri, 3 Feb 2023 at 08:45, Markus Armbruster <armbru@redhat.com> wrote:
>
>
> The following changes since commit deabea6e88f7c4c3c12a36ee30051c6209561165:
>
>   Merge tag 'for_upstream' of 
> https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2023-02-02 
> 10:10:07 +0000)
>
> are available in the Git repository at:
>
>   https://repo.or.cz/qemu/armbru.git tags/pull-monitor-2023-02-03
>
> for you to fetch changes up to 3a1cecf486ee97d5750931f81706c6d447615f17:
>
>   monitor: Rename misc.c to hmp-target.c (2023-02-03 09:14:17 +0100)
>
> ----------------------------------------------------------------
> Monitor patches for 2023-02-03
>
> ----------------------------------------------------------------

Compile failures, multiple jobs, eg:
https://gitlab.com/qemu-project/qemu/-/jobs/3711453887

../monitor/monitor.c:292:5: error: no previous prototype for
‘error_vprintf’ [-Werror=missing-prototypes]
int error_vprintf(const char *fmt, va_list ap)
^~~~~~~~~~~~~
../monitor/monitor.c: In function ‘error_vprintf’:
../monitor/monitor.c:297:9: error: function ‘error_vprintf’ might be a
candidate for ‘gnu_printf’ format attribute
[-Werror=suggest-attribute=format]
return monitor_vprintf(cur_mon, fmt, ap);
^~~~~~
../monitor/monitor.c:299:5: error: function ‘error_vprintf’ might be a
candidate for ‘gnu_printf’ format attribute
[-Werror=suggest-attribute=format]
return vfprintf(stderr, fmt, ap);
^~~~~~

The cross-win32-system job has more issues:
https://gitlab.com/qemu-project/qemu/-/jobs/3711453827

../monitor/hmp.c:1203:5: error: unknown type name 'DIR'
../monitor/hmp.c:1225:11: error: implicit declaration of function
'opendir'; did you mean 'open'?
[-Werror=implicit-function-declaration]

etc -- looks like some POSIX-only code is being built
when it shouldn't?

thanks
-- PMM