qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 09/35] readline: Extract readline_add_completion_of() from mon


From: Markus Armbruster
Subject: Re: [PULL 09/35] readline: Extract readline_add_completion_of() from monitor
Date: Wed, 08 Feb 2023 11:53:04 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 3/2/23 09:45, Markus Armbruster wrote:
>> monitor/misc.h has static add_completion_option().  It's useful
>> elsewhere in the monitor.  Since it's not monitor-specific, move it to
>> util/readline.c renamed to readline_add_completion_of(), and put it to
>> use.
>
> 52f50b1e9f8fd410d4293a211d549ec61b902728 is the first bad commit
>
> This commit broke monitor autocomplete feature.
>
> Before:
>
> (qemu) <tab>
> ?                                announce_self
> balloon                          block_job_cancel
> block_job_complete               block_job_pause
> block_job_resume                 block_job_set_speed
> [...]
>
> After:
>
> (qemu) <tab>
> [no autocomplete]

I'll look into it.  Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]