[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 09/35] readline: Extract readline_add_completion_of() from mon
From: |
Markus Armbruster |
Subject: |
Re: [PULL 09/35] readline: Extract readline_add_completion_of() from monitor |
Date: |
Wed, 08 Feb 2023 11:53:04 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 3/2/23 09:45, Markus Armbruster wrote:
>> monitor/misc.h has static add_completion_option(). It's useful
>> elsewhere in the monitor. Since it's not monitor-specific, move it to
>> util/readline.c renamed to readline_add_completion_of(), and put it to
>> use.
>
> 52f50b1e9f8fd410d4293a211d549ec61b902728 is the first bad commit
>
> This commit broke monitor autocomplete feature.
>
> Before:
>
> (qemu) <tab>
> ? announce_self
> balloon block_job_cancel
> block_job_complete block_job_pause
> block_job_resume block_job_set_speed
> [...]
>
> After:
>
> (qemu) <tab>
> [no autocomplete]
I'll look into it. Thanks!
- [PULL 32/35] monitor: Move remaining HMP commands from misc.c to hmp-cmds.c, (continued)
- [PULL 32/35] monitor: Move remaining HMP commands from misc.c to hmp-cmds.c, Markus Armbruster, 2023/02/03
- [PULL 19/35] net: Move hmp_info_network() to net-hmp-cmds.c, Markus Armbruster, 2023/02/03
- [PULL 22/35] virtio: Move HMP commands from monitor/ to hw/virtio/, Markus Armbruster, 2023/02/03
- [PULL 07/35] char: Factor out qmp_add_client() parts and move to chardev/, Markus Armbruster, 2023/02/03
- [PULL 10/35] hmp: Rename help_cmd() to hmp_help_cmd(), move declaration to hmp.h, Markus Armbruster, 2023/02/03
- [PULL 29/35] monitor: Split file descriptor passing stuff off misc.c, Markus Armbruster, 2023/02/03
- [PULL 27/35] acpi: Move the QMP command from monitor/ to hw/acpi/, Markus Armbruster, 2023/02/03
- [PULL 06/35] char: Move HMP commands from monitor/ to chardev/, Markus Armbruster, 2023/02/03
- [PULL 09/35] readline: Extract readline_add_completion_of() from monitor, Markus Armbruster, 2023/02/03
- [PULL 13/35] machine: Move HMP commands from monitor/ to hw/core/, Markus Armbruster, 2023/02/03
- Re: [PULL 00/35] Monitor patches for 2023-02-03, Peter Maydell, 2023/02/03