Re: [PATCH] tests/docker: Use binaries for debian-tricore-cross

[Bastian Koppelmann]

Hi Phil,

On Fri, Feb 03, 2023 at 04:02:16PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Bastian,
> 
> On 3/2/23 15:54, Bastian Koppelmann wrote:
> > since binutils is pretty old, it fails our CI repeatedly during the
> > compilation of tricore-binutils. We created a precompiled version using
> > the debian docker image and download it instead of building it ourself.
> > 
> > Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> > ---
> > Peter, I was having trouble with the new version of binutils, I mentioned. I
> > think this needs more time to sort out. So for now, let's just use a 
> > precompiled
> > version of the current binutils.
> > 
> >   .../dockerfiles/debian-tricore-cross.docker    | 18 +++---------------
> >   1 file changed, 3 insertions(+), 15 deletions(-)
> > 
> > diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker 
> > b/tests/docker/dockerfiles/debian-tricore-cross.docker
> > index 5ae58efa09..4abcf07e68 100644
> > --- a/tests/docker/dockerfiles/debian-tricore-cross.docker
> > +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker
> > @@ -16,32 +16,20 @@ MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>
> >   RUN apt update && \
> >       DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \
> >       DEBIAN_FRONTEND=noninteractive eatmydata apt install -yy \
> > -       bison \
> > +       curl \
> >          bzip2 \
> >          ca-certificates \
> > -       ccache \
> 
> You might not use ccache, but others do, so please let it:
> 
> $ git grep DOCKER_CCACHE
> tests/docker/Makefile.include:203:DOCKER_CCACHE_DIR :=
> $$HOME/.cache/qemu-docker-ccache
> tests/docker/Makefile.include:212:      @mkdir -p "$(DOCKER_CCACHE_DIR)"
> tests/docker/Makefile.include:234:                              -v
> $(DOCKER_CCACHE_DIR):/var/tmp/ccache:z \
> 
> > -       flex \
> > -       g++ \
> > -       gcc \
> > -       git \
> >          libglib2.0-dev \
> >          libpixman-1-dev \
> >          locales \
> > -       make \
> 
> Why remove gcc/(git)/make?

I'm not cloning any repository and not building anything. Why download things, 
if we
don't need them?

Anyways, if you prefer, then I can revert the changes to the installed packages.

Cheers,
Bastian