|
| From: | Richard Henderson |
| Subject: | Re: [PATCH v2 05/10] target/tricore: Fix RRPW_DEXTR |
| Date: | Thu, 2 Feb 2023 05:52:14 -1000 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 |
On 2/2/23 02:04, Bastian Koppelmann wrote:
if we used const16 == 0 we would crash qemu with the error:
../tcg/tcg-op.c:196: tcg_gen_shri_i32: Assertion `arg2 >= 0 && arg2 < 32' failed
This whole instruction can be handled by 'tcg_gen_extract2_tl' which
takes care of this special case as well.
Signed-off-by: Bastian Koppelmann<kbastian@mail.uni-paderborn.de>
---
v1 -> v2:
Use tcg_gen_extract2_tl and remove all special cases.
target/tricore/translate.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
| [Prev in Thread] | Current Thread | [Next in Thread] |