[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 01/10] target/tricore: Fix OPC2_32_RCRW_IMASK translation
From: |
Bastian Koppelmann |
Subject: |
[PATCH v2 01/10] target/tricore: Fix OPC2_32_RCRW_IMASK translation |
Date: |
Thu, 2 Feb 2023 13:04:23 +0100 |
we were mixing up the "c" and "d" registers. We used "d" as a
destination register und "c" as the source. According to the TriCore ISA
manual 1.6 vol 2 it is the other way round.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/653
---
target/tricore/translate.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index df9e46c649..8de4e56b1f 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -5794,11 +5794,11 @@ static void decode_rcrw_insert(DisasContext *ctx)
switch (op2) {
case OPC2_32_RCRW_IMASK:
- tcg_gen_andi_tl(temp, cpu_gpr_d[r4], 0x1f);
+ tcg_gen_andi_tl(temp, cpu_gpr_d[r3], 0x1f);
tcg_gen_movi_tl(temp2, (1 << width) - 1);
- tcg_gen_shl_tl(cpu_gpr_d[r3 + 1], temp2, temp);
+ tcg_gen_shl_tl(cpu_gpr_d[r4 + 1], temp2, temp);
tcg_gen_movi_tl(temp2, const4);
- tcg_gen_shl_tl(cpu_gpr_d[r3], temp2, temp);
+ tcg_gen_shl_tl(cpu_gpr_d[r4], temp2, temp);
break;
case OPC2_32_RCRW_INSERT:
temp3 = tcg_temp_new();
--
2.39.1
- [PATCH v2 00/10] TriCore instruction bugfixes, Bastian Koppelmann, 2023/02/02
- [PATCH v2 08/10] tests/tcg/tricore: Add OPC2_32_RRRR_DEXTR tests, Bastian Koppelmann, 2023/02/02
- [PATCH v2 09/10] target/tricore: Fix OPC2_32_BO_LD_BU_PREINC, Bastian Koppelmann, 2023/02/02
- [PATCH v2 02/10] tests/tcg/tricore: Add test for OPC2_32_RCRW_IMASK, Bastian Koppelmann, 2023/02/02
- [PATCH v2 06/10] tests/tcg/tricore: Add tests for RRPW_DEXTR, Bastian Koppelmann, 2023/02/02
- [PATCH v2 05/10] target/tricore: Fix RRPW_DEXTR, Bastian Koppelmann, 2023/02/02
- [PATCH v2 03/10] target/tricore: Fix OPC2_32_RCRW_INSERT translation, Bastian Koppelmann, 2023/02/02
- [PATCH v2 01/10] target/tricore: Fix OPC2_32_RCRW_IMASK translation,
Bastian Koppelmann <=
- [PATCH v2 07/10] target/tricore: Fix OPC2_32_RRRR_DEXTR, Bastian Koppelmann, 2023/02/02
- [PATCH v2 04/10] tests/tcg/tricore: Add test for OPC2_32_RCRW_INSERT, Bastian Koppelmann, 2023/02/02
- [PATCH v2 10/10] tests/tcg/tricore: Add LD.BU tests, Bastian Koppelmann, 2023/02/02