[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI |
|
Date: |
Mon, 28 Nov 2022 14:27:56 +0000 |
|
User-agent: |
Mutt/2.2.7 (2022-08-07) |
* Markus Armbruster (armbru@redhat.com) wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
>
> > * Markus Armbruster (armbru@redhat.com) wrote:
> >> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when
> >> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when
> >> !CONFIG_PCI. Build pci-hmp-cmds.c that way, too.
> >>
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >
> > Had you considered wrapping the hmp-commands-info.hx entry
> > with a #if defined instead?
>
> No. Would you prefer that?
It seemed a bit simpler to me, but I'm not too fussed.
I kind of preferred the idea of the command giving an error if there's
no PCI built in.
> Code containing #ifdef CONFIG_PCI is target-dependent. Looks like the
> affected monitor code already is, so no new headaches.
> Aside: splitting off its target-independent parts could be nice. Not
> today.
Yeh.
Dave
> [...]
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH 06/12] pci: Deduplicate get_class_desc(), (continued)
Re: [PATCH 00/12] pci: Move and clean up monitor command code, Michael S. Tsirkin, 2022/11/28
Re: [PATCH 00/12] pci: Move and clean up monitor command code, Michael S. Tsirkin, 2022/11/28