[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI |
|
Date: |
Mon, 28 Nov 2022 14:38:42 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
> * Markus Armbruster (armbru@redhat.com) wrote:
>> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when
>> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when
>> !CONFIG_PCI. Build pci-hmp-cmds.c that way, too.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Had you considered wrapping the hmp-commands-info.hx entry
> with a #if defined instead?
No. Would you prefer that?
Code containing #ifdef CONFIG_PCI is target-dependent. Looks like the
affected monitor code already is, so no new headaches.
Aside: splitting off its target-independent parts could be nice. Not
today.
[...]
- Re: [PATCH 04/12] pci: Make query-pci stub consistent with the real one, (continued)
Re: [PATCH 00/12] pci: Move and clean up monitor command code, Michael S. Tsirkin, 2022/11/28
Re: [PATCH 00/12] pci: Move and clean up monitor command code, Michael S. Tsirkin, 2022/11/28