Re: [PATCH 09/12] pci: Move HMP command from hw/pci/pcie_aer.c to pci-hmp-cmds.c

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 28/11/22 09:01, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>   hw/pci/pci-internal.h   |   4 ++
>>   include/monitor/hmp.h   |   1 +
>>   include/sysemu/sysemu.h |   3 --
>>   hw/pci/pci-hmp-cmds.c   | 105 ++++++++++++++++++++++++++++++++++++
>>   hw/pci/pci-stub.c       |   1 -
>>   hw/pci/pcie_aer.c       | 115 ++--------------------------------------
>>   6 files changed, 114 insertions(+), 115 deletions(-)
>
> I suppose hmp_info_usb() is next :)

The smaller the monitor/{hmp,qmp)-cmds.c grabbags, the better.

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!