[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/6] migration: All this fields are unsigned
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v2 1/6] migration: All this fields are unsigned |
|
Date: |
Fri, 24 Dec 2021 17:38:22 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Peter Xu <peterx@redhat.com> wrote:
> On Tue, Dec 21, 2021 at 01:52:30PM +0100, Juan Quintela wrote:
>> So printing it as %d is wrong. Notice that for the channel id, that
>> is an uint8_t, but I changed it anyways for consistency.
>
> Just curious: uint_8 can always correctly converted to a int, so the patch
> shouldn't have a functional change, right?
Yeap. My understanding of C promotion rules is that everything is
promoted to int by default, if the size is smaller than positive part of
it, that is ok.
But once there, I reviewed all "%d", and if it was unsigned, I change it
to "%u".
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
Thanks, Juan.
- [PATCH v2 0/6] migration: misc cleanups, Juan Quintela, 2021/12/21
- [PATCH v2 1/6] migration: All this fields are unsigned, Juan Quintela, 2021/12/21
- [PATCH v2 2/6] migration: We only need last_stage in two places, Juan Quintela, 2021/12/21
- [PATCH v2 3/6] migration: ram_release_pages() always receive 1 page as argument, Juan Quintela, 2021/12/21
- [PATCH v2 4/6] migration: Remove masking for compression, Juan Quintela, 2021/12/21
- [PATCH v2 5/6] migration: simplify do_compress_ram_page, Juan Quintela, 2021/12/21
- [PATCH v2 6/6] migration: Move ram_release_pages() call to save_zero_page_to_file(), Juan Quintela, 2021/12/21