qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 0/6] migration: misc cleanups


From: Juan Quintela
Subject: [PATCH v2 0/6] migration: misc cleanups
Date: Tue, 21 Dec 2021 13:52:29 +0100

Hi

Changes since v1:
- Add reviewed tags for reviewed patches
- Change comment about last_stage (philmd)
- Change cast to 1ULL for ram_release_page()
- remove TARGET_PAGE_MASK mask.  It was used only for compression,
  and offset should be page aligned already

Please, review.

Thanks, Juan.

[v1]
This series do several cleanups:
- Dave found that I was using "%d" for unsigned, fix all uses.
- We pass last_stage left and right, but we only use it in two places
  Just move it to RAMState.
- do_compress_page() used a goto when not needed.
- ram_release_pages() was always used with one page
- And put it when we detect zero pages, instead of everywhere we have find a 
zero page.

Please, review.

Juan Quintela (6):
  migration: All this fields are unsigned
  migration: We only need last_stage in two places
  migration: ram_release_pages() always receive 1 page as argument
  migration: Remove masking for compression
  migration: simplify do_compress_ram_page
  migration: Move ram_release_pages() call to save_zero_page_to_file()

 migration/multifd-zlib.c | 20 +++++------
 migration/multifd-zstd.c | 24 +++++++-------
 migration/multifd.c      | 16 ++++-----
 migration/ram.c          | 71 +++++++++++++++++-----------------------
 migration/trace-events   | 26 +++++++--------
 5 files changed, 73 insertions(+), 84 deletions(-)

-- 
2.33.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]