qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/6] migration: ram_release_pages() always receive 1 page


From: Peter Xu
Subject: Re: [PATCH v2 3/6] migration: ram_release_pages() always receive 1 page as argument
Date: Fri, 24 Dec 2021 15:24:55 +0800

On Tue, Dec 21, 2021 at 01:52:32PM +0100, Juan Quintela wrote:
> -static void ram_release_pages(const char *rbname, uint64_t offset, int pages)
> +static void ram_release_page(const char *rbname, uint64_t offset)
>  {
>      if (!migrate_release_ram() || !migration_in_postcopy()) {
>          return;
>      }
>  
> -    ram_discard_range(rbname, offset, ((ram_addr_t)pages) << 
> TARGET_PAGE_BITS);
> +    ram_discard_range(rbname, offset, 1ULL << TARGET_PAGE_BITS);

This is TARGET_PAGE_SIZE, afaict.. anyway,

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu




reply via email to

[Prev in Thread] Current Thread [Next in Thread]