[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: does drive_get_next(IF_NONE) make sense?
From: |
Peter Maydell |
Subject: |
Re: does drive_get_next(IF_NONE) make sense? |
Date: |
Sun, 14 Nov 2021 17:16:35 +0000 |
On Fri, 12 Nov 2021 at 13:34, Markus Armbruster <armbru@redhat.com> wrote:
>
> Thomas Huth <thuth@redhat.com> writes:
>
> > On 03/11/2021 09.41, Markus Armbruster wrote:
> >> Peter Maydell <peter.maydell@linaro.org> writes:
> >>
> >>> Does it make sense for a device/board to do drive_get_next(IF_NONE) ?
> >> Short answer: hell, no! ;)
> >
> > Would it make sense to add an "assert(type != IF_NONE)" to drive_get()
> > to avoid such mistakes in the future?
>
> Worth a try.
You need to fix the sifive_u_otp device first :-)
-- PMM
- does drive_get_next(IF_NONE) make sense?, Peter Maydell, 2021/11/02
- Re: does drive_get_next(IF_NONE) make sense?, Philippe Mathieu-Daudé, 2021/11/02
- Re: does drive_get_next(IF_NONE) make sense?, Markus Armbruster, 2021/11/03
- Re: does drive_get_next(IF_NONE) make sense?, Thomas Huth, 2021/11/03
- Re: does drive_get_next(IF_NONE) make sense?, Markus Armbruster, 2021/11/12
- Re: does drive_get_next(IF_NONE) make sense?,
Peter Maydell <=
- Re: does drive_get_next(IF_NONE) make sense?, Markus Armbruster, 2021/11/15
- Re: does drive_get_next(IF_NONE) make sense?, Alistair Francis, 2021/11/15
- Re: does drive_get_next(IF_NONE) make sense?, Thomas Huth, 2021/11/15
- Re: does drive_get_next(IF_NONE) make sense?, Alistair Francis, 2021/11/18
- Re: does drive_get_next(IF_NONE) make sense?, Peter Maydell, 2021/11/18
- Re: does drive_get_next(IF_NONE) make sense?, Kevin Wolf, 2021/11/15
- Re: does drive_get_next(IF_NONE) make sense?, Peter Maydell, 2021/11/15
- Re: does drive_get_next(IF_NONE) make sense?, Kevin Wolf, 2021/11/15
- Re: does drive_get_next(IF_NONE) make sense?, Markus Armbruster, 2021/11/15