[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704)

From: Richard Henderson
Subject: Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704)
Date: Wed, 10 Nov 2021 10:27:40 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 11/9/21 5:46 PM, Warner Losh wrote:

On Nov 7, 2021, at 5:48 AM, Richard Henderson <richard.henderson@linaro.org> 

There are a number of alignement issues flagged up by clang,
this attempts to fix only one of them: getdents.

Does it make sense to have size asserts for these types? That would catch the 
alignment issues and are cheap to maintain since ABI sizes should never change…

Well, the size of getdents64 doesn't change; it merely lands at a different memory offset. But we've now told the compiler about it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]