[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] linux-user: Always use flexible arrays for dirent d_name
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 2/4] linux-user: Always use flexible arrays for dirent d_name |
Date: |
Mon, 8 Nov 2021 08:40:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 11/7/21 13:48, Richard Henderson wrote:
> We currently use a flexible array member for target_dirent,
> but use incorrectly fixed length arrays for target_dirent64,
> linux_dirent and linux_dirent64.
>
> This requires that we adjust the definition of the VFAT READDIR
> ioctls which hard-code the 256 namelen size into the ioctl constant.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/syscall_defs.h | 6 +++---
> linux-user/syscall.c | 6 ++++--
> 2 files changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 0/4] linux-user: Fix getdents alignment issues (#704), Richard Henderson, 2021/11/07
- [PATCH 1/4] linux-user: Split out do_getdents, do_getdents64, Richard Henderson, 2021/11/07
- [PATCH 3/4] linux-user: Fix member types of target_dirent64, Richard Henderson, 2021/11/07
- [PATCH 4/4] linux-user: Rewrite do_getdents, do_getdents64, Richard Henderson, 2021/11/07
- [PATCH 2/4] linux-user: Always use flexible arrays for dirent d_name, Richard Henderson, 2021/11/07
- Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704), Warner Losh, 2021/11/09
- Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704), Laurent Vivier, 2021/11/10