[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704)
From: |
Warner Losh |
Subject: |
Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704) |
Date: |
Tue, 9 Nov 2021 09:46:46 -0700 |
> On Nov 7, 2021, at 5:48 AM, Richard Henderson <richard.henderson@linaro.org>
> wrote:
>
> There are a number of alignement issues flagged up by clang,
> this attempts to fix only one of them: getdents.
Does it make sense to have size asserts for these types? That would catch the
alignment issues and are cheap to maintain since ABI sizes should never change…
Warner
> r~
>
> Richard Henderson (4):
> linux-user: Split out do_getdents, do_getdents64
> linux-user: Always use flexible arrays for dirent d_name
> linux-user: Fix member types of target_dirent64
> linux-user: Rewrite do_getdents, do_getdents64
>
> linux-user/syscall_defs.h | 12 +-
> linux-user/syscall.c | 290 ++++++++++++++++++--------------------
> 2 files changed, 141 insertions(+), 161 deletions(-)
>
> --
> 2.25.1
>
>
- [PATCH 1/4] linux-user: Split out do_getdents, do_getdents64, (continued)
- [PATCH 1/4] linux-user: Split out do_getdents, do_getdents64, Richard Henderson, 2021/11/07
- [PATCH 3/4] linux-user: Fix member types of target_dirent64, Richard Henderson, 2021/11/07
- [PATCH 4/4] linux-user: Rewrite do_getdents, do_getdents64, Richard Henderson, 2021/11/07
- [PATCH 2/4] linux-user: Always use flexible arrays for dirent d_name, Richard Henderson, 2021/11/07
- Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704),
Warner Losh <=
- Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704), Laurent Vivier, 2021/11/10