Re: [PATCH v2 08/43] bsd-user: pass the bsd_param into loader_exec

[Warner Losh]

> On Aug 26, 2021, at 10:22 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
> On 8/26/21 11:11 PM, imp@bsdimp.com wrote:
>> From: Warner Losh <imp@bsdimp.com>
>> 
>> Pass the bsd_param into loader_exec, and adjust.
> 
> Missing the "why" justification.

So I am. I’ve added it and it will be in v3 of the patches. It’s used to share 
state between
bsdload and elf load, especially open files and the stack used to construct the 
initial args
to start/main.

Warner

> Anyway,
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
>> Signed-off-by: Warner Losh <imp@bsdimp.com>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> bsd-user/bsdload.c | 37 +++++++++++++++++++------------------
>> bsd-user/main.c    |  7 ++++++-
>> bsd-user/qemu.h    |  3 ++-
>> 3 files changed, 27 insertions(+), 20 deletions(-)

signature.asc
Description: Message signed with OpenPGP