qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/43] bsd-user: move arch specific defines out of elfload


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 07/43] bsd-user: move arch specific defines out of elfload.c
Date: Fri, 27 Aug 2021 06:19:24 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 8/26/21 11:11 PM, imp@bsdimp.com wrote:
> From: Warner Losh <imp@bsdimp.com>
> 
> Move the arcitecture specific defines to target_arch_elf.h and delete

Typo "architecture"

> them from elfload.c. unifdef as appropriate for i386 vs x86_64

"un-ifdef" or untangle?

> versions. Add the copyright/license comments, and guard ifdefs.
> 
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  bsd-user/elfload.c                | 81 +------------------------------
>  bsd-user/i386/target_arch_elf.h   | 76 +++++++++++++++++++++++++++++
>  bsd-user/x86_64/target_arch_elf.h | 64 ++++++++++++++++++++++++
>  3 files changed, 142 insertions(+), 79 deletions(-)
>  create mode 100644 bsd-user/i386/target_arch_elf.h
>  create mode 100644 bsd-user/x86_64/target_arch_elf.h



reply via email to

[Prev in Thread] Current Thread [Next in Thread]