[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 09/43] bsd-user: Fix calculation of size to allocate
From: |
imp |
Subject: |
[PATCH v2 09/43] bsd-user: Fix calculation of size to allocate |
Date: |
Thu, 26 Aug 2021 15:11:27 -0600 |
From: Warner Losh <imp@bsdimp.com>
It was incorrect to subtract off the size of an unsigned int here. In
bsd-user fork, this change was made when moving the arch specific items
to specific files. The size in BSD that's available for the arguments
does not need a return address subtracted from it.
Signed-off-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
bsd-user/bsdload.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/bsd-user/bsdload.c b/bsd-user/bsdload.c
index 5282a7c4f2..379015c744 100644
--- a/bsd-user/bsdload.c
+++ b/bsd-user/bsdload.c
@@ -143,10 +143,9 @@ int loader_exec(const char *filename, char **argv, char
**envp,
struct target_pt_regs *regs, struct image_info *infop,
struct bsd_binprm *bprm)
{
- int retval;
- int i;
+ int retval, i;
- bprm->p = TARGET_PAGE_SIZE * MAX_ARG_PAGES - sizeof(unsigned int);
+ bprm->p = TARGET_PAGE_SIZE * MAX_ARG_PAGES;
for (i = 0; i < MAX_ARG_PAGES; i++) { /* clear page-table */
bprm->page[i] = NULL;
}
--
2.32.0
- [PATCH v2 00/43] bsd-user updates to run hello world, imp, 2021/08/26
- [PATCH v2 02/43] bsd-user: add copyright header to elfload.c, imp, 2021/08/26
- [PATCH v2 03/43] bsd-user: Add Stacey's copyright to main.c, imp, 2021/08/26
- [PATCH v2 04/43] bsd-user: add license to bsdload.c, imp, 2021/08/26
- [PATCH v2 05/43] bsd-user: style nits: bsdload.c whitespace to qemu standard, imp, 2021/08/26
- [PATCH v2 01/43] bsd-user: remove sparc and sparc64, imp, 2021/08/26
- [PATCH v2 06/43] bsd-user: Remove all non-x86 code from elfload.c, imp, 2021/08/26
- [PATCH v2 08/43] bsd-user: pass the bsd_param into loader_exec, imp, 2021/08/26
- [PATCH v2 09/43] bsd-user: Fix calculation of size to allocate,
imp <=
- [PATCH v2 07/43] bsd-user: move arch specific defines out of elfload.c, imp, 2021/08/26
- [PATCH v2 10/43] bsd-user: implement path searching, imp, 2021/08/26
- [PATCH v2 11/43] bsd-user: Eliminate elf personality, imp, 2021/08/26
- [PATCH v2 12/43] bsd-user: remove a.out support, imp, 2021/08/26
- [PATCH v2 14/43] bsd-user: elfload: simplify bswap a bit., imp, 2021/08/26
- [PATCH v2 15/43] bsd-user: assume pthreads and support of __thread, imp, 2021/08/26