Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check
Date:	Sun, 18 Jul 2021 09:54:33 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/18/21 12:18 AM, Richard Henderson wrote:
> Since 0b00b0c1e05b, tb->size must not be zero.
> Advance pc so that the breakpoint covers the insn at the bp.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/avr/translate.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 04/13] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain, (continued)
- [PATCH v3 04/13] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain, Richard Henderson, 2021/07/17
- [PATCH v3 05/13] accel/tcg: Handle -singlestep in curr_cflags, Richard Henderson, 2021/07/17
- [PATCH v3 09/13] target/mips: Reduce mips_tr_breakpoint_check pc advance to 2, Richard Henderson, 2021/07/17
  - Re: [PATCH v3 09/13] target/mips: Reduce mips_tr_breakpoint_check pc advance to 2, Peter Maydell, 2021/07/17
  - Re: [PATCH v3 09/13] target/mips: Reduce mips_tr_breakpoint_check pc advance to 2, Philippe Mathieu-Daudé, 2021/07/18
- [PATCH v3 07/13] accel/tcg: Move cflags lookup into tb_find, Richard Henderson, 2021/07/17
- [PATCH v3 02/13] accel/tcg: Move curr_cflags into cpu-exec.c, Richard Henderson, 2021/07/17
- [PATCH v3 06/13] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic, Richard Henderson, 2021/07/17
- [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check, Richard Henderson, 2021/07/17
  - Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check, Peter Maydell, 2021/07/17
  - Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check, Philippe Mathieu-Daudé <=
  - Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check, Philippe Mathieu-Daudé, 2021/07/19
- [PATCH v3 12/13] accel/tcg: Hoist tb_cflags to a local in translator_loop, Richard Henderson, 2021/07/17
- [PATCH v3 03/13] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR, Richard Henderson, 2021/07/17
- [PATCH v3 13/13] accel/tcg: Encode breakpoint info into tb->cflags, Richard Henderson, 2021/07/17
  - Re: [PATCH v3 13/13] accel/tcg: Encode breakpoint info into tb->cflags, Peter Maydell, 2021/07/19
- [PATCH v3 11/13] accel/tcg: Adjust interface of TranslatorOps.breakpoint_check, Richard Henderson, 2021/07/17
- [PATCH v3 10/13] target/riscv: Reduce riscv_tr_breakpoint_check pc advance to 2, Richard Henderson, 2021/07/17
  - Re: [PATCH v3 10/13] target/riscv: Reduce riscv_tr_breakpoint_check pc advance to 2, Peter Maydell, 2021/07/17
    - Re: [PATCH v3 10/13] target/riscv: Reduce riscv_tr_breakpoint_check pc advance to 2, Richard Henderson, 2021/07/18
    - Re: [PATCH v3 10/13] target/riscv: Reduce riscv_tr_breakpoint_check pc advance to 2, Peter Maydell, 2021/07/18

Prev by Date: Re: [PATCH v3 09/13] target/mips: Reduce mips_tr_breakpoint_check pc advance to 2
Next by Date: Re: [PATCH for-6.2 03/10] linux-user: Split signal-related prototypes into sighandling.h
Previous by thread: Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check
Next by thread: Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check
Index(es):
- Date
- Thread