Re: [PULL v2 04/15] gitlab-ci.yml: Add jobs to test CFI flags

[Alex Bennée]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> On 3/10/21 4:59 PM, Alex Bennée wrote:
>> From: Daniele Buono <dbuono@linux.vnet.ibm.com>
>> 
>> QEMU has had options to enable control-flow integrity features
>> for a few months now. Add two sets of build/check/acceptance
>> jobs to ensure the binary produced is working fine.
>> 
>> The three sets allow testing of x86_64 binaries for x86_64, s390x,
>> ppc64 and aarch64 targets
>> 
>> [AJB: tweak job names to avoid brands]
>> 
>> Signed-off-by: Daniele Buono <dbuono@linux.vnet.ibm.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Message-Id: <20210304030948.9367-3-dbuono@linux.vnet.ibm.com>
>> Message-Id: <20210305092328.31792-9-alex.bennee@linaro.org>
>
>> +build-cfi-x86_64:
>> +  <<: *native_build_job_definition
>> +  needs:
>> +  - job: amd64-fedora-container
>> +  variables:
>> +    LD_JOBS: 1
>> +    AR: llvm-ar
>> +    IMAGE: fedora
>> +    CONFIGURE_ARGS: --cc=clang --cxx=clang++ --enable-cfi --enable-cfi-debug
>> +      --enable-safe-stack --enable-slirp=git
>> +    TARGETS: x86_64-softmmu
>> +    MAKE_CHECK_ARGS: check-build
>> +  artifacts:
>> +    expire_in: 2 days
>> +    paths:
>> +      - build
>
> FYI this job is timeouting:
>
> ERROR: Job failed: execution took longer than 1h0m0s seconds
>
> https://gitlab.com/qemu-project/qemu/-/jobs/1112829128
>

I didn't see it fail in my tests (although visibility is somewhat masked
by the current failing iotest). However I notice the builds are fairly
close to the limit (56-58 mins). As they are already pared down maybe
just increasing "timeout" is enough?

>> +
>> +check-cfi-x86_64:
>> +  <<: *native_test_job_definition
>> +  needs:
>> +    - job: build-cfi-x86_64
>> +      artifacts: true
>> +  variables:
>> +    IMAGE: fedora
>> +    MAKE_CHECK_ARGS: check
>> +
>> +acceptance-cfi-x86_64:
>> +  <<: *native_test_job_definition
>> +  needs:
>> +    - job: build-cfi-x86_64
>> +      artifacts: true
>> +  variables:
>> +    IMAGE: fedora
>> +    MAKE_CHECK_ARGS: check-acceptance
>> +  <<: *acceptance_definition
>> +
>>  tsan-build:
>>    <<: *native_build_job_definition
>>    variables:
>> 


-- 
Alex Bennée