[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 08/15] hw/riscv: migrate fdt field to generic MachineState
From: |
Alex Bennée |
Subject: |
[PULL v2 08/15] hw/riscv: migrate fdt field to generic MachineState |
Date: |
Wed, 10 Mar 2021 15:59:55 +0000 |
This is a mechanical change to make the fdt available through
MachineState.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210303173642.3805-3-alex.bennee@linaro.org>
diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h
index 84b7a3848f..632da52018 100644
--- a/include/hw/riscv/virt.h
+++ b/include/hw/riscv/virt.h
@@ -41,7 +41,6 @@ struct RISCVVirtState {
DeviceState *plic[VIRT_SOCKETS_MAX];
PFlashCFI01 *flash[2];
- void *fdt;
int fdt_size;
};
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index 4f0c2fbca0..0b39101a5e 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -195,14 +195,14 @@ static void create_fdt(RISCVVirtState *s, const
MemMapEntry *memmap,
hwaddr flashbase = virt_memmap[VIRT_FLASH].base;
if (mc->dtb) {
- fdt = s->fdt = load_device_tree(mc->dtb, &s->fdt_size);
+ fdt = mc->fdt = load_device_tree(mc->dtb, &s->fdt_size);
if (!fdt) {
error_report("load_device_tree() failed");
exit(1);
}
goto update_bootargs;
} else {
- fdt = s->fdt = create_device_tree(&s->fdt_size);
+ fdt = mc->fdt = create_device_tree(&s->fdt_size);
if (!fdt) {
error_report("create_device_tree() failed");
exit(1);
@@ -444,12 +444,12 @@ static void create_fdt(RISCVVirtState *s, const
MemMapEntry *memmap,
g_free(name);
name = g_strdup_printf("/soc/flash@%" PRIx64, flashbase);
- qemu_fdt_add_subnode(s->fdt, name);
- qemu_fdt_setprop_string(s->fdt, name, "compatible", "cfi-flash");
- qemu_fdt_setprop_sized_cells(s->fdt, name, "reg",
+ qemu_fdt_add_subnode(mc->fdt, name);
+ qemu_fdt_setprop_string(mc->fdt, name, "compatible", "cfi-flash");
+ qemu_fdt_setprop_sized_cells(mc->fdt, name, "reg",
2, flashbase, 2, flashsize,
2, flashbase + flashsize, 2, flashsize);
- qemu_fdt_setprop_cell(s->fdt, name, "bank-width", 4);
+ qemu_fdt_setprop_cell(mc->fdt, name, "bank-width", 4);
g_free(name);
update_bootargs:
@@ -667,9 +667,9 @@ static void virt_machine_init(MachineState *machine)
hwaddr end = riscv_load_initrd(machine->initrd_filename,
machine->ram_size, kernel_entry,
&start);
- qemu_fdt_setprop_cell(s->fdt, "/chosen",
+ qemu_fdt_setprop_cell(machine->fdt, "/chosen",
"linux,initrd-start", start);
- qemu_fdt_setprop_cell(s->fdt, "/chosen", "linux,initrd-end",
+ qemu_fdt_setprop_cell(machine->fdt, "/chosen", "linux,initrd-end",
end);
}
} else {
@@ -690,12 +690,12 @@ static void virt_machine_init(MachineState *machine)
/* Compute the fdt load address in dram */
fdt_load_addr = riscv_load_fdt(memmap[VIRT_DRAM].base,
- machine->ram_size, s->fdt);
+ machine->ram_size, machine->fdt);
/* load the reset vector */
riscv_setup_rom_reset_vec(machine, &s->soc[0], start_addr,
virt_memmap[VIRT_MROM].base,
virt_memmap[VIRT_MROM].size, kernel_entry,
- fdt_load_addr, s->fdt);
+ fdt_load_addr, machine->fdt);
/* SiFive Test MMIO device */
sifive_test_create(memmap[VIRT_TEST].base);
--
2.20.1
- [PULL v2 04/15] gitlab-ci.yml: Add jobs to test CFI flags, (continued)
- [PULL v2 04/15] gitlab-ci.yml: Add jobs to test CFI flags, Alex Bennée, 2021/03/10
- [PULL v2 05/15] tests/docker: Use --arch-only when building Debian cross image, Alex Bennée, 2021/03/10
- [PULL v2 12/15] docs: add some documentation for the guest-loader, Alex Bennée, 2021/03/10
- [PULL v2 13/15] tests/avocado: add boot_xen tests, Alex Bennée, 2021/03/10
- [PULL v2 07/15] hw/board: promote fdt from ARM VirtMachineState to MachineState, Alex Bennée, 2021/03/10
- [PULL v2 11/15] docs: move generic-loader documentation into the main manual, Alex Bennée, 2021/03/10
- [PULL v2 15/15] semihosting: Move hw/semihosting/ -> semihosting/, Alex Bennée, 2021/03/10
- [PULL v2 08/15] hw/riscv: migrate fdt field to generic MachineState,
Alex Bennée <=
- [PULL v2 10/15] hw/core: implement a guest-loader to support static hypervisor guests, Alex Bennée, 2021/03/10
- [PULL v2 14/15] semihosting: Move include/hw/semihosting/ -> include/semihosting/, Alex Bennée, 2021/03/10
- [PULL v2 09/15] device_tree: add qemu_fdt_setprop_string_array helper, Alex Bennée, 2021/03/10
- Re: [PULL v2 00/15] testing, docs, semihosting move and guest-loader, Peter Maydell, 2021/03/11