Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock

From:	Paolo Bonzini
Subject:	Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock
Date:	Mon, 22 Mar 2021 14:54:30 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 22/03/21 11:47, Keqian Zhu wrote:

+    qemu_mutex_init(&kml_slots_lock);

As you said, x86 has two address spaces, is it a problem that we may have multi 
initialization for kml_slots_lock?


Agreed, the lock can be initialized (if only for cleanliness) in kvm_init.

Paolo

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v5 00/10] KVM: Dirty ring support (QEMU part), Peter Xu, 2021/03/10
- [PATCH v5 01/10] memory: Introduce log_sync_global() to memory listener, Peter Xu, 2021/03/10
- [PATCH v5 03/10] KVM: Create the KVMSlot dirty bitmap on flag changes, Peter Xu, 2021/03/10
- [PATCH v5 04/10] KVM: Provide helper to get kvm dirty log, Peter Xu, 2021/03/10
- [PATCH v5 05/10] KVM: Provide helper to sync dirty bitmap from slot to ramblock, Peter Xu, 2021/03/10
- [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock, Peter Xu, 2021/03/10
  - Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock, Keqian Zhu, 2021/03/22
    - Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock, Paolo Bonzini <=
    - Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock, Peter Xu, 2021/03/22
    - Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock, Peter Xu, 2021/03/24
- [PATCH v5 08/10] KVM: Add dirty-gfn-count property, Peter Xu, 2021/03/10
- [PATCH v5 09/10] KVM: Disable manual dirty log when dirty ring enabled, Peter Xu, 2021/03/10
  - Re: [PATCH v5 09/10] KVM: Disable manual dirty log when dirty ring enabled, Keqian Zhu, 2021/03/22
    - Re: [PATCH v5 09/10] KVM: Disable manual dirty log when dirty ring enabled, Paolo Bonzini, 2021/03/22
    - Re: [PATCH v5 09/10] KVM: Disable manual dirty log when dirty ring enabled, Peter Xu, 2021/03/22
- [PATCH v5 06/10] KVM: Simplify dirty log sync in kvm_set_phys_mem, Peter Xu, 2021/03/10
- [PATCH v5 10/10] KVM: Dirty ring support, Peter Xu, 2021/03/10
  - Re: [PATCH v5 10/10] KVM: Dirty ring support, Keqian Zhu, 2021/03/22

Prev by Date: Re: [PATCH] optionrom/pvh: use memcmp() to find the RSDP signature
Next by Date: Re: [RFC] accel: add cpu_reset
Previous by thread: Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock
Next by thread: Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock
Index(es):
- Date
- Thread