[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock |
|
Date: |
Mon, 22 Mar 2021 12:27:54 -0400 |
On Mon, Mar 22, 2021 at 02:54:30PM +0100, Paolo Bonzini wrote:
> On 22/03/21 11:47, Keqian Zhu wrote:
> > > + qemu_mutex_init(&kml_slots_lock);
> > As you said, x86 has two address spaces, is it a problem that we may have
> > multi initialization for kml_slots_lock?
>
> Agreed, the lock can be initialized (if only for cleanliness) in kvm_init.
Definitely, I'm surprised why I didn't see this... :) Paolo, do you want me to
add another patch (as attached)?
--
Peter Xu
0001-qemu-thread-Assert-and-check-mutex-re-initialize.patch
Description: Text document
- [PATCH v5 00/10] KVM: Dirty ring support (QEMU part), Peter Xu, 2021/03/10
- [PATCH v5 01/10] memory: Introduce log_sync_global() to memory listener, Peter Xu, 2021/03/10
- [PATCH v5 03/10] KVM: Create the KVMSlot dirty bitmap on flag changes, Peter Xu, 2021/03/10
- [PATCH v5 04/10] KVM: Provide helper to get kvm dirty log, Peter Xu, 2021/03/10
- [PATCH v5 05/10] KVM: Provide helper to sync dirty bitmap from slot to ramblock, Peter Xu, 2021/03/10
- [PATCH v5 02/10] KVM: Use a big lock to replace per-kml slots_lock, Peter Xu, 2021/03/10
[PATCH v5 08/10] KVM: Add dirty-gfn-count property, Peter Xu, 2021/03/10
[PATCH v5 09/10] KVM: Disable manual dirty log when dirty ring enabled, Peter Xu, 2021/03/10
[PATCH v5 06/10] KVM: Simplify dirty log sync in kvm_set_phys_mem, Peter Xu, 2021/03/10
[PATCH v5 10/10] KVM: Dirty ring support, Peter Xu, 2021/03/10