This function now warns, except for "help" and "?". The exception
applies even when we treat "help" and "?" as sugar for "help=on" and
"?=on" because opts_accepts_any().
Right, because again help_wanted will be false for non-validated QemuOptsList.
Summary: only qemu_opts_parse_noisily() warns. This is airtight only if
all user input flows through qemu_opts_parse_noisily().
HMP doesn't. But that's too hard to change now, and it's not considered as much of a stable interface as the command line.
Anyway I am not going to push this for 5.2. Thanks for the speedy reviews anyway!
Paolo