Re: [PATCH v2 6/6] qemu-option: warn for short-form boolean options

[Markus Armbruster]

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il lun 9 nov 2020, 22:19 Markus Armbruster <armbru@redhat.com> ha scritto:
>
>> This function now warns, except for "help" and "?".  The exception
>> applies even when we treat "help" and "?" as sugar for "help=on" and
>> "?=on" because opts_accepts_any().
>>
>
> Right, because again help_wanted will be false for non-validated
> QemuOptsList.
>
>> Summary: only qemu_opts_parse_noisily() warns.  This is airtight only if
>> all user input flows through qemu_opts_parse_noisily().
>
>
> HMP doesn't. But that's too hard to change now, and it's not considered as
> much of a stable interface as the command line.
>
> Anyway I am not going to push this for 5.2. Thanks for the speedy reviews
> anyway!

You're welcome!  It was worth a try.  We can try again for 6.0 without
time pressure.