[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register |
Date: |
Wed, 24 Jun 2020 10:01:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 24/06/20 09:47, Thomas Huth wrote:
>>
>> {
>> /* hands over all ports from companion uhci to ehci */
>> - qpci_io_writew(ehci1.dev, ehci1.bar, 0x60, 1);
>> + qpci_io_writel(ehci1.dev, ehci1.bar, 0x60, 1);
>> }
>> static void pci_uhci_port_2(void)
>
> Passes "make check-qtest-x86_64" on a s390x host, too:
>
> Tested-by: Thomas Huth <thuth@redhat.com>
Ah, I see what you mean now, so I'll clarify. Endianness is handled by
the memory core and libqos so for little-endian devices (such as PCI
devices) it's okay. For big-endian using the wrong size would not work,
but it should fail the same on LE and BE hosts. endianness-test checks
that.
Paolo