[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register |
Date: |
Tue, 23 Jun 2020 16:56:14 -0400 |
On Tue, Jun 23, 2020 at 12:18:52PM -0400, Paolo Bonzini wrote:
> The memory region ops have min_access_size == 4 so obey it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Makes sense.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
I assume you are queueing this with the memory core change.
> ---
> tests/qtest/usb-hcd-ehci-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/usb-hcd-ehci-test.c b/tests/qtest/usb-hcd-ehci-test.c
> index 5251d539e9..c51e8bb223 100644
> --- a/tests/qtest/usb-hcd-ehci-test.c
> +++ b/tests/qtest/usb-hcd-ehci-test.c
> @@ -96,7 +96,7 @@ static void pci_ehci_port_1(void)
> static void pci_ehci_config(void)
> {
> /* hands over all ports from companion uhci to ehci */
> - qpci_io_writew(ehci1.dev, ehci1.bar, 0x60, 1);
> + qpci_io_writel(ehci1.dev, ehci1.bar, 0x60, 1);
> }
>
> static void pci_uhci_port_2(void)
> --
> 2.26.2