Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour

[no-reply]

Patchew URL: 
20200613040518.38172-1-geoff@hostfission.com/">https://patchew.org/QEMU/20200613040518.38172-1-geoff@hostfission.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200613040518.38172-1-geoff@hostfission.com
Subject: [PATCH 0/6] audio/jack: fixes to overall jack behaviour
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c962352 audio/jack: simplify the re-init code path
1b80c6e audio/jack: honour the enable state of the audio device
d549d5e0 audio/jack: do not remove ports when finishing
d9f3c84 audio/jack: remove invalid set of input support bool
c612550 audio/jack: remove unused stopped state
62d579e audio/jack: fix invalid minimum buffer size check

=== OUTPUT BEGIN ===
1/6 Checking commit 62d579e00e55 (audio/jack: fix invalid minimum buffer size 
check)
2/6 Checking commit c612550cb58e (audio/jack: remove unused stopped state)
3/6 Checking commit d9f3c846ec2f (audio/jack: remove invalid set of input 
support bool)
4/6 Checking commit d549d5e05a30 (audio/jack: do not remove ports when 
finishing)
5/6 Checking commit 1b80c6eb42f5 (audio/jack: honour the enable state of the 
audio device)
ERROR: space required before the open parenthesis '('
#42: FILE: audio/jackaudio.c:277:
+            for(int i = 0; i < c->nchannels; ++i) {

total: 1 errors, 0 warnings, 91 lines checked

Patch 5/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/6 Checking commit c9623522cfe0 (audio/jack: simplify the re-init code path)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200613040518.38172-1-geoff@hostfission.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200613040518.38172-1-geoff@hostfission.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com