[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/6] audio/jack: remove invalid set of input support bool
From: |
Geoffrey McRae |
Subject: |
[PATCH 3/6] audio/jack: remove invalid set of input support bool |
Date: |
Sat, 13 Jun 2020 14:05:15 +1000 |
Initial code for JACK did not support audio input and as such this
boolean was set to let QEMU know, however JACK ended up including input
support making this invalid. Further investigation shows it was invalid
to set it in the first instance anyway due to a failure on my part
understand properly what this was for when the audodev was initially
developed.
Signed-off-by: Geoffrey McRae <geoff@hostfission.com>
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index fb8efd7af7..58c7344497 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -607,9 +607,6 @@ static int qjack_thread_creator(jack_native_thread_t
*thread,
static void *qjack_init(Audiodev *dev)
{
assert(dev->driver == AUDIODEV_DRIVER_JACK);
-
- dev->u.jack.has_in = false;
-
return dev;
}
--
2.20.1
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, (continued)
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Gerd Hoffmann, 2020/06/17
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Geoffrey McRae, 2020/06/17
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Gerd Hoffmann, 2020/06/19
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Geoffrey McRae, 2020/06/21
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Gerd Hoffmann, 2020/06/22
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Geoffrey McRae, 2020/06/22
[PATCH 2/6] audio/jack: remove unused stopped state, Geoffrey McRae, 2020/06/14
[PATCH 4/6] audio/jack: do not remove ports when finishing, Geoffrey McRae, 2020/06/14
[PATCH 1/6] audio/jack: fix invalid minimum buffer size check, Geoffrey McRae, 2020/06/14
[PATCH 6/6] audio/jack: simplify the re-init code path, Geoffrey McRae, 2020/06/14
[PATCH 3/6] audio/jack: remove invalid set of input support bool,
Geoffrey McRae <=
Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour, no-reply, 2020/06/14